feat: add cursor styles, click ripples, and GPUI frame controls - #2156
Conversation
|
hey @greptileai, please re-review the PR |
| export type CursorConfiguration = { hide: boolean; hideWhenIdle: boolean; hideWhenIdleDelay: number; size: number; type: CursorType; animationStyle: CursorAnimationStyle; tension: number; mass: number; friction: number; raw: boolean; motionBlur: number; useSvg: boolean; rotationAmount?: number; baseRotation?: number; clickSpring?: ClickSpringConfig | null; stopMovementInLastSeconds?: number | null; ripple?: CursorRippleConfig } | ||
| export type CursorMeta = { imagePath: string; hotspot: XY<number>; shape?: string | null } | ||
| export type CursorType = "auto" | "pointer" | "circle" | ||
| export type CursorRippleConfig = { enabled: boolean; color: [number, number, number]; strength: number; size: number; duration: number } | ||
| export type CursorType = "auto" | "pointer" | "circle" | "macos" | "tahoe" | "windows" |
There was a problem hiding this comment.
Generated bindings edited directly
These declarations directly modify a generated tauri.ts file, contrary to the repository requirement that binding changes come from the authoritative generator. Regeneration can overwrite manual declarations and obscure whether the Rust binding source remains aligned.
Context Used: AGENTS.md (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop/src/utils/tauri.ts
Line: 918-921
Comment:
**Generated bindings edited directly**
These declarations directly modify a generated `tauri.ts` file, contrary to the repository requirement that binding changes come from the authoritative generator. Regeneration can overwrite manual declarations and obscure whether the Rust binding source remains aligned.
**Context Used:** AGENTS.md ([source](https://github.com/capsoftware/cap/blob/main/AGENTS.md))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.|
hey @greptileai, please re-review the PR |
Manage your Superagent protectionSuperagent has paused scans for this repository because this unlinked GitHub App installation has used all three included PR scans. You have 0 of 3 included PR scans remaining. Create a free account to continue protection, manage scan settings, review security history, and control which repositories are protected. |
Adds macOS, Tahoe, Windows, and circle cursor controls to both desktop editors, with configurable click ripples in the shared renderer and backward-compatible project settings.
Adds GPUI window/device frame controls, fixes Space-key playback when controls have focus, and lets the renderer CLI capture a chosen timeline position.
Validated Rust formatting, scoped Biome checks, desktop TypeScript, and native compilation of cap-cursor-info, cap-project, and cap-rendering using the GPUI workspace. Added four click-ripple regression tests covering cursor freeze, timing, visibility, and bounded instances. Native tests and the existing Tauri binding-export test could not complete locally because executable startup stalled; those jobs were stopped. Native Windows/Linux interaction testing has not been performed. Remaining CI jobs are still running.
Greptile Summary
The PR adds selectable cursor styles, configurable click ripples, GPUI frame controls, improved focused-control playback handling, and timeline-position capture support.
Confidence Score: 5/5
The PR appears safe to merge because no blocking failure remains in the previously reviewed areas.
No blocking failure remains.
Important Files Changed
Reviews (3): Last reviewed commit: "chore: trim narrative comments from curs..." | Re-trigger Greptile
Context used (3)