#27 fix: check out skills-vendor/ in the test job - #30
Merged
Conversation
tests/test_skills_hook.py dereferences the .claude/hooks/ symlink into skills-vendor/, so it needs a populated submodule, not merely a correctly-shaped link. actions/checkout does not fetch submodules by default, so the link dangled on the runner and the test could not pass in CI at all — red on main since 7bf5988, 443 of 444. `true` rather than `recursive`: neither submodule nests, so recursion only adds a foreach pass. Scoped to the test job — ruff never reads skills-vendor/. Both remotes are public HTTPS, so this needs no token and does not touch the wheelhouse WIF auth. Unrelated to the #22 v1.2 hold in both directions: the suspended refresh is a developer-machine SessionStart hook CI never invokes, and checkout resolves the SHA pinned here rather than upstream tip, so the pin the hold froze stays frozen. The assertion message named only the local remedy, which reads as nonsense on a runner; it now names both. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27.
tests/test_skills_hook.py::test_the_hook_the_symlink_points_at_actually_existsdereferences the
.claude/hooks/symlink intoskills-vendor/.actions/checkoutdoes not fetch submodules by default, so the link dangled on the runner and the test
could not pass in CI at all —
mainred since7bf5988, 443 of 444.Change
One key on the
testjob's checkout, plus the comment explaining why it is load-bearing.true, notrecursive— neither submodule carries a.gitmodules, so recursiononly adds a
foreachpass to checkout and post-job cleanup.testjob only — ruff never readsskills-vendor/; fetching two submodules torun a linter is cost for nothing.
.gitmodules. No token, no WIF,no wheelhouse impact.
Also widens the assertion message, which named only
.skills/doctor.sh— developer-machineadvice that reads as nonsense on a runner.
Correcting the issue's evidence table
The third row is misattributed. Run 31117568515
(Merge #26) failed at
Set up jobwithFailed to resolve action download info. Error: Service Unavailable— yesterday's Actions outage. It never reachedcheckout, let alonepytest, and its
lintjob was cancelled at 15m rather than failed. Two runs share thiscause, not three;
afb1f97would have failed the same way, but that was never observed.On the #22 v1.2 hold
Unaffected in both directions. The suspended refresh is a developer-machine SessionStart
hook CI never invokes, and
checkoutresolves the SHA pinned in this superproject ratherthan upstream tip — so the pin the hold froze stays frozen.
Verification
444 passed, 18 deselected(was 443 + 1 failed in CI).testgreen with 444, not 443 — the second assertion isos.access(HOOK, os.X_OK), andthe target is mode
100755in the skills index.lintuntouched and still green.baseline.
Coupling accepted knowingly
The
testjob now depends on two third-party public repos being fetchable at checkout.An upstream force-push that GCs a pinned SHA would fail the job at checkout — an error
that looks nothing like a test failure. Noted in the workflow comment so the next person
reading a checkout failure knows where to look.
🤖 Generated with Claude Code