Fix bincode dependency: revert to 2.0.0-rc.3 and remove derive feature - #203
Closed
dependabot[bot] wants to merge 2 commits into
Closed
Fix bincode dependency: revert to 2.0.0-rc.3 and remove derive feature#203dependabot[bot] wants to merge 2 commits into
dependabot[bot] wants to merge 2 commits into
Conversation
Updates the requirements on [bincode](https://github.com/bincode-org/bincode) to permit the latest version. - [Commits](https://github.com/bincode-org/bincode/commits) --- updated-dependencies: - dependency-name: bincode dependency-version: 2.0.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Collaborator
|
@copilot fix the build error (remove the |
Done in the latest commit. I also had to revert the version from |
Copilot
AI
changed the title
Update bincode requirement from 2.0.0-rc.3 to 3.0.0
Fix bincode dependency: revert to 2.0.0-rc.3 and remove derive feature
May 29, 2026
Collaborator
|
@dependabot ignore this dependency |
Author
|
OK, I won't notify you about bincode again, unless you re-open this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the build error introduced by updating
bincodeto3.0.0. Thebincode 3.0.0package on crates.io is a protest/joke package that unconditionally emits acompile_error!and cannot be compiled. This PR reverts thebincoderequirement back to2.0.0-rc.3(which resolves to the actualv2.0.1release) and removes the unusedderivefeature flag.Changes Made
bincodefrom3.0.0back to2.0.0-rc.3in bothCargo.tomlandsrc/kete_core/Cargo.tomlderivefeature (unused in the codebase); retained theserdefeature required bybincode::serde::*APIs used throughout the codeTesting
cargo checkcompletes successfully, resolving tobincode v2.0.1