Fix Thold integration dependency installation#777
Open
somethingwithproof wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions integration-test workflow to avoid installing an Ubuntu-versioned Apache PHP module that is not reliably available across the PHP matrix, relying instead on setup-php for the CLI PHP runtime.
Changes:
- Removed
libapache2-mod-php${{ matrix.php }}from the system dependency installation step in the integration workflow.
|
|
||
| - name: Install System Dependencies | ||
| run: sudo apt-get install -y apache2 snmp snmpd rrdtool fping libapache2-mod-php${{ matrix.php }} | ||
| run: sudo apt-get install -y apache2 snmp snmpd rrdtool fping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The matrix PHP executable is supplied by
setup-php; the integration suite runs through the CLI and does not require an Apache module.Validation
git diff --checkKept separate from #773 so the security hardening remains focused.