Repository navigation
fix: avoid PHP 8.6 deprecations in schema caching - #457
Merged
Merged
Conversation
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
|
TheWitness
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #456.
Use
spl_object_id()for the request-local schema cache key to avoid PHP 8.6 deprecation warnings during Syslog page loads. Cached definitions retain their connection objects; a regression test checks that one connection’s successful creation does not skip another connection’s schema check. No SQL or schema changes.Validation: seven schema compatibility tests passed on PHP 8.2 and 8.5 (25 assertions each); PHP 7.4 syntax check passed. The broader local suite exposed an existing missing-procfs warning and a container PID-1 assumption in the process-helper tests; those are outside this change. PHP 8.6 behavior will be checked by the existing CI matrix.