Repository navigation
feature: add built-in device types for ten more switch vendors - #208
Merged
Merged
Conversation
Seed Juniper Junos, Arista EOS, HPE Aruba CX, Extreme EXOS, Huawei VRP and Fortinet FortiOS as SSH capture device types, and Ruckus ICX, Ubiquiti EdgeSwitch, Netgear Managed and TP-Link JetStream as TFTP device types. Existing device types with the same name are never overwritten. Document the new types in the README and CHANGELOG. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Real-device or vendor-backed validation is needed for SSH execution, complete unpaginated output, and TFTP privilege and confirmation flows because the seed tests only inspect inserted parameters.
No open issues 🎉
What changed in this PR
Adds ten built-in vendor device types to the Cacti routerconfigs plugin, using the existing SSH capture and TFTP backup paths. Install and upgrade seeding preserves existing definitions with matching names.
Changes:
- Adds six SSH capture definitions and four TFTP definitions.
- Updates seed-count assertions to 16 and adds command and connection-type checks.
- Documents the new defaults and the need for device-specific validation; real hardware testing remains outstanding.
| File | Description |
|---|---|
tests/Unit/RouterconfigsSetupTableTest.php |
Checks all 16 defaults and the new capture and TFTP seed parameters. |
tests/Unit/RouterconfigsCheckUpgradeTest.php |
Updates the expected upgrade seed count to 16. |
tests/Integration/RouterconfigsInstallHooksTest.php |
Updates the expected installation seed count to 16. |
setup.php |
Adds ten vendor definitions through the existing guarded seeding helper. |
README.md |
Lists built-in types, backup methods, and device-specific requirements. |
CHANGELOG.md |
Records the expanded vendor defaults and firmware-validation caveat. |
Review effort: Balanced
xmacan
approved these changes
Nov 16, 2026
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Adds built-in device types for ten managed-switch vendors the plugin did not cover. They are seeded on install and upgrade through the existing
AddDeviceType()guard, so existing or customized device types with the same name are never overwritten. No schema or code-path changes; this builds on the Capture Command added in #207.show configurationshow running-configshow running-configshow configurationdisplay current-configurationshow full-configurationcopy running-config tftp %SERVER% %FILE%copy nvram:startup-config tftp://%SERVER%/%FILE%copy nvram:startup-config tftp://%SERVER%/%FILE%copy startup-config tftp ip-address %SERVER% filename %FILE%SSH capture types need no TFTP server and never fall back to Telnet.
checkendinconfigis left off for all of them, so a config that does not end inendis not rejected.Testing