fix(security): defense-in-depth hardening for plugin_audit - #52
fix(security): defense-in-depth hardening for plugin_audit#52somethingwithproof wants to merge 7 commits into
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
There was a problem hiding this comment.
Pull request overview
Defense-in-depth hardening for the Cacti audit plugin, focused on reducing attack surface (XSS mitigation in UI output) and adding repository-level security automation (CodeQL + Dependabot).
Changes:
- Escape the
pagerequest variable before rendering it into an HTML hidden input. - Add a CodeQL workflow for JavaScript/TypeScript analysis.
- Add a Dependabot configuration for GitHub Actions (and npm).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
audit.php |
Escapes a request variable before embedding it into HTML output. |
.github/workflows/codeql.yml |
Introduces CodeQL scanning workflow (JS/TS matrix). |
.github/dependabot.yml |
Enables Dependabot updates for GitHub Actions and npm. |
|
Converted to draft to serialize the stack in this repo. Blocked by #51; will un-draft after that merges to avoid cross-PR merge conflicts. |
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
- Change Dependabot ecosystem from npm to composer (PHP-only repo) - Remove PHP from CodeQL paths-ignore so security PRs get analysis - Remove committed .omc session artifacts, add .omc/ to .gitignore Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
ba0eb4f to
1a8b1c8
Compare
# Conflicts: # .github/dependabot.yml # .github/workflows/plugin-ci-workflow.yml # .gitignore # audit.php # audit_functions.php # setup.php
|
Closing as superseded after rebasing against current develop. The advertised XSS, prepared-statement, and safe-unserialize changes are already present in develop; the remaining PR diff is unrelated CodeQL/locale churn, so there is no in-scope change left to merge. |
Summary
Defense-in-depth hardening addressing 7 security audit findings.
html_escape_request_var()allowed_classes => falsetounserialize()All changes PHP 7.0+ compatible.
Test plan