Repository navigation
Conversation
codeflight1
reviewed
Oct 2, 2026
codeflight1
left a comment
codeflight1
left a comment
Contributor
There was a problem hiding this comment.
Looking good, we can test on-rover this Saturday
codeflight1
requested changes
Oct 6, 2026
| ros, | ||
| name: CURRENT_MOTORS[key].topic, | ||
| messageType: 'ros_phoenix/msg/MotorStatus', | ||
| throttle_rate: 100, |
Contributor
There was a problem hiding this comment.
Lets remove this, the messages are already published at 10 hz and we don't want to introduce unnecessary delay
| <button onClick={downloadPNG}>PNG</button> | ||
| </div> | ||
| </div> | ||
|
|
Contributor
There was a problem hiding this comment.
There's a couple extra blank lines in here that can be removed. The line above and the one below should also be indented by 2 more spaces.
| } from 'recharts'; | ||
|
|
||
| const WINDOW_MS = 60 * 1000; | ||
| const DEFAULT_MAX_AMPS = 12; |
Contributor
There was a problem hiding this comment.
12 amps is a lot for our motors, lets make it 2
| return () => unsubscribers.forEach((unsub) => unsub()); | ||
| }, [ros]); | ||
|
|
||
| const formatTime = (time: number) => |
Contributor
There was a problem hiding this comment.
The graph will be easier to read if this shows relative time (eg 30 sec) instead of absolute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.