Joss review fixes - #8
Merged
Merged
Conversation
- paper/figures/figure2.py imports matplotlib, but it was undeclared anywhere in pyproject.toml; a reviewer following the README's own 'pip install -e .' + 'python paper/figures/figure2.py' instructions would hit ModuleNotFoundError. Add a 'figures' extra and update README/tutorials.md instructions accordingly. - The sdist had no include/exclude config, so it bundled the entire repo (paper.pdf, all figure exports, dev notes, .claude/, .github/), ballooning it to 2.27MB. Constrain sdist/wheel targets to just the package, tests, README, and LICENSE (23.7KB). - Regenerate figure exports and paper.pdf as part of verification.
Note: np.random.seed() no longer influences these generators. Pass rng instead.
Use float(fr.item()), which is correct for any single-element array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.