Skip to content

fix(encoding): use ASCII status output - #180

Merged
tjzegmott merged 2 commits into
CHIMEFRB:mainfrom
WVURAIL:djg/fix-ascii-output
Aug 26, 2026
Merged

fix(encoding): use ASCII status output#180
tjzegmott merged 2 commits into
CHIMEFRB:mainfrom
WVURAIL:djg/fix-ascii-output

Conversation

@djgormley

@djgormley djgormley commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Replaces non-ASCII status symbols in command output and logs while preserving the stderr update banner.

@djgormley
djgormley requested a review from tjzegmott August 25, 2026 17:29
@djgormley
djgormley marked this pull request as ready for review August 25, 2026 17:29
@djgormley
djgormley marked this pull request as draft August 25, 2026 17:31
@djgormley
djgormley marked this pull request as ready for review August 25, 2026 17:33
@djgormley
djgormley marked this pull request as draft August 25, 2026 17:33
@djgormley djgormley self-assigned this Aug 25, 2026
@djgormley djgormley added the BUG Something isn't working label Aug 25, 2026
@djgormley djgormley changed the title fix: use ASCII status output fix(encoding): use ASCII status output Aug 25, 2026
@djgormley
djgormley force-pushed the djg/fix-ascii-output branch from 159d7f6 to 32d6287 Compare August 25, 2026 20:50
@djgormley
djgormley marked this pull request as ready for review August 25, 2026 21:13
@djgormley
djgormley enabled auto-merge August 25, 2026 21:17
@djgormley

Copy link
Copy Markdown
Contributor Author

@tjzegmott It's generally better practice to use ASCII characters to guarantee any system can render it. That's all that's happening here.

tjzegmott
tjzegmott previously approved these changes Aug 26, 2026

@tjzegmott tjzegmott left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand it is a small change, the volume of PRs to review will take me a little time to get through. Lacks the visual punch by switching to ascii, particularly in the deletion warning but will approve anyway.

@djgormley
djgormley dismissed tjzegmott’s stale review August 26, 2026 15:40

The merge-base changed after approval.

@djgormley

Copy link
Copy Markdown
Contributor Author

I understand it is a small change, the volume of PRs to review will take me a little time to get through. Lacks the visual punch by switching to ascii, particularly in the deletion warning but will approve anyway.

I mean you're the maintainer it's up to you. If you want to keep them you should proabably switch them to unicode at least.

@djgormley
djgormley disabled auto-merge August 26, 2026 15:45
tjzegmott
tjzegmott previously approved these changes Aug 26, 2026
@djgormley
djgormley dismissed tjzegmott’s stale review August 26, 2026 17:03

The merge-base changed after approval.

@djgormley

Copy link
Copy Markdown
Contributor Author

@tjzegmott This went stale because you pushed after I submitted this PR. I just did a fetch. Nothing changed. Reapprove. Thanks.

@tjzegmott
tjzegmott merged commit a0646d7 into CHIMEFRB:main Aug 26, 2026
6 checks passed
@djgormley
djgormley deleted the djg/fix-ascii-output branch August 26, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BUG Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants