fix(encoding): use ASCII status output - #180
Conversation
159d7f6 to
32d6287
Compare
|
@tjzegmott It's generally better practice to use ASCII characters to guarantee any system can render it. That's all that's happening here. |
tjzegmott
left a comment
There was a problem hiding this comment.
I understand it is a small change, the volume of PRs to review will take me a little time to get through. Lacks the visual punch by switching to ascii, particularly in the deletion warning but will approve anyway.
The merge-base changed after approval.
I mean you're the maintainer it's up to you. If you want to keep them you should proabably switch them to unicode at least. |
The merge-base changed after approval.
|
@tjzegmott This went stale because you pushed after I submitted this PR. I just did a fetch. Nothing changed. Reapprove. Thanks. |
Replaces non-ASCII status symbols in command output and logs while preserving the stderr update banner.