feat(ps): expose per-storage-element common paths in --json output - #176
Open
djgormley wants to merge 2 commits into
Open
feat(ps): expose per-storage-element common paths in --json output#176djgormley wants to merge 2 commits into
djgormley wants to merge 2 commits into
Conversation
djgormley
marked this pull request as draft
August 24, 2026 23:52
djgormley
marked this pull request as ready for review
August 25, 2026 17:14
djgormley
marked this pull request as draft
August 25, 2026 21:21
djgormley
force-pushed
the
feat/ps-common-path
branch
from
August 25, 2026 21:37
b26d11c to
a189b14
Compare
djgormley
marked this pull request as ready for review
August 25, 2026 21:46
djgormley
enabled auto-merge
August 25, 2026 21:46
djgormley
disabled auto-merge
August 26, 2026 15:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Composing download paths from
ps --jsonrequires re-deriving the common directory split that the files table computes internally (ps,pull, andcreate_files_tableeach inline it today). This adds acommon_pathsfield to the--jsonpayload: per storage element, the deepest common directory and the file names relative to it.The derivation lives in
utilities.common_paths(), andcreate_files_tablenow renders from the same helper -- which also fixes the single-file case, where the table previously showed the file itself as the common path with- .as the entry. An element with no usable split reportscommon_path: ""with the original paths, so nothing is hidden. Unit tests cover the split and no-split cases; the liveps --jsontest now asserts the field.