yanglint BUGFIX const qualifier violation in cmd_load - #2574
Open
mferreirarivier wants to merge 1 commit into
Open
mferreirarivier wants to merge 1 commit into
mferreirarivier wants to merge 1 commit into
Conversation
cmd_load_exec is called with an immutable string as posv. Cast of strchr return silently discards that const qualifier, so posv ends up modified in cmd_load regardless of it. Duplicate an owned copy before splitting the name and the revision, the same way it is done in cmd_print. Signed-off-by: Matthieu Ferreira Rivier <matthieu.ferreira-rivier@6wind.com>
Member
|
Thanks, but change the target branch to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmd_load_exec is called with an immutable string as posv. Cast of strchr return silently discards that const qualifier, so posv ends up modified in cmd_load regardless of it.
Duplicate an owned copy before splitting the name and the revision, the same way it is done in cmd_print.