Skip to content

fix(base): keep DOIs in pids even it's reference #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzacharo merged 1 commit into from
Aug 14, 2026
Merged

fix(base): keep DOIs in pids even it's reference #576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cds_migrator_kit/rdm/records/transform/xml_processing/rules/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,6 +483,7 @@ def _pids(self, key, value):
# if we have a qualifier for one of these two, we know it references
# an external resource (checked in DB and individually on records)
# if qualifier == ebook, it references itself, so qualifier is not needed
# if it's a doi, we should also need to keep it as external doi
if qualifier == "thesis":
qualifier = "publication-thesis"
related_works = self.get("related_identifiers", [])
Expand All @@ -502,6 +503,9 @@ def _pids(self, key, value):
if new_id not in related_works:
related_works.append(new_id)
self["related_identifiers"] = related_works
if is_doi_id or scheme == "doi":
pid_dict["doi"] = {"identifier": identifier}

@zzacharo zzacharo Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont we need a scheme for external?

@zubeydecivelek zubeydecivelek Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's handled here
https://github.com/CERNDocumentServer/cds-migrator-kit/blob/master/cds_migrator_kit/rdm/records/transform/transform.py#L223-L230

self["_pids"] = pid_dict
raise IgnoreKey("_pids")

if scheme.upper() in PID_SCHEMES_TO_STORE_IN_IDENTIFIERS:
Expand Down Expand Up @@ -870,7 +874,7 @@ def related_identifiers_787(self, key, value):
"resource_type": {"id": "publication-periodicalarticle"},
},
"report": {
"relation_type": {"id": "isderivedfrom"},
"relation_type": {"id": "references"},
"resource_type": {"id": "publication-report"},
},
"preprint": {
Expand Down
Loading