feat(rdm.migration): Configurable auto-adding secondary community - #544
feat(rdm.migration): Configurable auto-adding secondary community#544sakshamarora1 wants to merge 4 commits into
Conversation
bf187da to
4eab511
Compare
4eab511 to
53f4ac6
Compare
| "publication-book", | ||
| "publication-section", | ||
| "publication-conferencepaper", | ||
| "publication-conferenceproceeding", |
There was a problem hiding this comment.
to add: 'publication-conferencenote', added recently
| """ | ||
| if self.restricted or record.get("access") != "public": | ||
| return False | ||
| if any(file.get("status") for file in entry.get("files", [])): |
There was a problem hiding this comment.
are you sure that this covers everything? I would also check if the output json in access.files has it set to restricted or not
There was a problem hiding this comment.
I tested all the possible scenarios in the test cases. Could you also check that and let me know if something is missing?
There is no access.files populated in this flow. Do you mean here? It only sets enabled key
cds-migrator-kit/cds_migrator_kit/rdm/records/transform/transform.py
Lines 781 to 785 in 059313b
cds-migrator-kit/cds_migrator_kit/rdm/records/transform/transform.py
Lines 240 to 244 in 059313b
There was a problem hiding this comment.
thanks for checking this. One more case comes to mind: we can set the whole collection to restricted, in this case we shouldn't add the scientific community either
There was a problem hiding this comment.
closes: #542
https://codimd.web.cern.ch/g3bn8n7LRimDeil-TDDIlA