Repository navigation
Automation lanes size by their bottom edge in the arranger - #57
Open
marcin-koziol wants to merge 1 commit into
Open
marcin-koziol wants to merge 1 commit into
marcin-koziol wants to merge 1 commit into
Conversation
Automation lanes were a fixed 56 px: a track showing them could only size its own part (the edge between it and its lanes), and the bottom of its block, where one reaches for, did nothing. Each lane now sizes by its bottom edge in the header column (a few pixels either side, the cursor and a highlight say so): the lane alone grows or shrinks, the rows below move, the track's own part keeps its height. Double-click: the default height again. The height is the layout's, like a take lane's (Workspace::automation_lane_heights by lane, 32–400 px, the default not stored; Action::SetAutomationLaneHeight, not undoable, view-only for scripts and scenes). Test an_automation_lane_resizes_by_its_bottom_edge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Automation lanes in the arranger had a fixed height of 56 px. On a track showing automation, the only edge that resized anything was the one between the track's own part and its lanes. The bottom edge of the whole block, which is the one people naturally grab, did nothing. So an automation lane could not be made taller to edit its curve more precisely.
Change
Workspace::automation_lane_heights, keyed by lane id, clamped to 32–400 px. The default height is not stored.Action::SetAutomationLaneHeight. It is not undoable and is treated as view-only by scripts and scenes.AUTO_LANE_His now the default height (AUTOMATION_LANE_HEIGHT). Lane geometry and row heights read each lane's own height.Tests
an_automation_lane_resizes_by_its_bottom_edge. It checks that the edge is hit on both sides, that dragging grows only the lane, that the rows below move, and that a double-click restores the default.faderframe-view-arranger: 96 tests pass.faderframe-workspace: 16 tests pass.🤖 Generated with Claude Code