GAUD-10313 - Fix jitter if pulling the panel backwards when collapsed - #7426
Closed
svanherk wants to merge 1 commit into
Closed
GAUD-10313 - Fix jitter if pulling the panel backwards when collapsed#7426svanherk wants to merge 1 commit into
svanherk wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
Contributor
Author
|
Ignore this for now, still trying to find something better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may be a Windows-only thing, as I can only make it happen on certain screen sizes/monitors. But if you try to pull the divider backwards while collapsed, you get this jittering:

You also get the big Windows scrollbar appearing, and then animating away.

It's really complicated to not have the scrollbar appear at all, since we need it there as we start dragging open.
The easiest way to fix this is to turn off animating until you're actually opening the panel. I think this looks better, but it does mean you "snap back" to closed if you didn't pull the panel far enough to open:

And here it is with a scrollbar:

If this solution is not acceptable, I can go back to the drawing board, but this is the cleanest I've found so far.