GAUD-9962: iterator component - #7423
Draft
dlockhart wants to merge 7 commits into
Draft
Conversation
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
dlockhart
commented
Aug 27, 2026
|
|
||
| describe('d2l-button-iterator', () => { | ||
|
|
||
| Object.entries(buttonIteratorFixtures).forEach(([name, template]) => { |
Member
Author
There was a problem hiding this comment.
I couldn't think of a state I didn't want to put through axe, so 🤷
dbatiste
reviewed
Aug 28, 2026
| #previousId = getUniqueId(); | ||
| #nextId = getUniqueId(); | ||
|
|
||
| #handleNextClicked(e) { |
Contributor
There was a problem hiding this comment.
Not a big deal but these two handlers could be done with a general #handleButtonClick that checks e.target.disabled, and then e.target.id to determine which event to dispatch.
Contributor
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I still have a few outstanding design questions for Glen when he's back, but I think it's worth getting this in and we can address them after.