Repository navigation
Review fixes: keep start-up on passive updates, safer admin-rights switch - #25
Merged
Merged
Conversation
…itch - Installer: pre-uninstall hook also skips on /UPDATE (the updater's passive mode is not silent), so updates keep the Run key, marker and tasks. - admin_rights/login_item: fail if the Run key cannot be removed instead of ignoring it; clearer error when Launch at login cannot be restored. - Capture: DXGI retry in GDI fallback is 500 ms (was 2 s) so recovery after lock/UAC stays quick. - device: hold logic as pure helpers (hold_remaining, skip_frame) with real tests. - --has-tasks reuses admin_mode(); one setAdminRights() helper in the UI re-reads the real state. - CLAUDE.md: Launch at login description matches the new Run-key default. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что исправлено (по ревью релиза 1.1.0)
/UPDATE(passive-режим апдейтера не silent). Обновления больше не стирают Run-ключ, маркерStartupAskedи задачи.hold_remaining/skip_frame, тесты проверяют реальное поведение.--has-tasksиспользуетadmin_mode(); в UI одинsetAdminRights()для кнопки и чекбокса, после действия перечитывается реальное состояние.CLAUDE.md: описание Launch at login соответствует Run-ключу по умолчанию.Проверка
cargo fmt --check,cargo test(117 passed),clippy -D warnings— зелёные локально./UPDATEчерезshlwapi::StrStrIW) и JS-хелпер. Нужна сборка установщика в CI и проверка автообновления на ленте.🤖 Generated with Claude Code