Repository navigation
Review follow-ups: per-strip lock-key hold, idle poll, fewer allocations - #23
Merged
Merged
Conversation
BrenOne
commented
Nov 3, 2026
BrenOne
commented
Owner
- Each Controller keeps its own output FPS for the lock-key hold, instead of one global that several strips overwrote.
- The lock-key poll idles (100 ms) while no strip runs above 30 FPS.
- The frame path clones Settings only when brightness/minimum glow differ.
- With GDI fallback active, DXGI duplication is retried every 2 s, not 250 ms.
- parse_info() split out of query_info() and tested, plus a hold test.
- Each Controller keeps its own output FPS for the lock-key hold, instead of one global that several strips overwrote. - The lock-key poll idles (100 ms) while no strip runs above 30 FPS. - The frame path clones Settings only when brightness/minimum glow differ. - With GDI fallback active, DXGI duplication is retried every 2 s, not 250 ms. - parse_info() split out of query_info() and tested, plus a hold test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.