Skip to content

fix(ci): avoid SIGPIPE failures in macOS package checks - #532

Merged
Warhammer4000 merged 1 commit into
devfrom
fix/ci-pkg-version-check
Nov 17, 2026
Merged

Warhammer4000 merged 1 commit into
devfrom
fix/ci-pkg-version-check

Conversation

@Warhammer4000

@Warhammer4000 Warhammer4000 commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

The Build macOS package job failed on #531: "$bin" -version | grep -q '0.0.1' under pipefail fails when grep exits on its first match and the binary then gets SIGPIPE. The log shows SentinelGo version: v0.0.1 followed by "wrong version".

  • CI: capture the lipo -archs, -version and launchctl print output before matching or truncating it.
  • scripts/macos-pkg.sh: same for the codesign -dv probe. A SIGPIPE there would skip the slice-signature check on a certificate-signed release.

CI-only plus a release script, with no agent behavior change, so skip-changelog.

🤖 Generated with Claude Code


Devin Review

With pipefail, `cmd | grep -q` (and `| head`) fails when the reader exits
early and the writer gets SIGPIPE. The pkg job's version check failed on
#531 although the output contained v0.0.1. Capture the output first, in the
CI checks and in macos-pkg.sh's signature probe, where the race would skip
verification of a signed build.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Warhammer4000 Warhammer4000 added the skip-changelog No user-visible change; no CHANGELOG.md entry needed label Nov 17, 2026
@coderabbitai

coderabbitai Bot commented Nov 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2f5e1c0b-ee80-4a3b-8fe6-967fd4a79d20

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@sonarqubecloud

Copy link
Copy Markdown

@Warhammer4000
Warhammer4000 merged commit aa12e9d into dev Nov 17, 2026
25 of 26 checks passed
@Warhammer4000
Warhammer4000 deleted the fix/ci-pkg-version-check branch November 17, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog No user-visible change; no CHANGELOG.md entry needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant