Repository navigation
fix(ci): avoid SIGPIPE failures in macOS package checks - #532
Merged
Merged
Conversation
With pipefail, `cmd | grep -q` (and `| head`) fails when the reader exits early and the writer gets SIGPIPE. The pkg job's version check failed on #531 although the output contained v0.0.1. Capture the output first, in the CI checks and in macos-pkg.sh's signature probe, where the race would skip verification of a signed build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The
Build macOS packagejob failed on #531:"$bin" -version | grep -q '0.0.1'underpipefailfails when grep exits on its first match and the binary then gets SIGPIPE. The log showsSentinelGo version: v0.0.1followed by "wrong version".lipo -archs,-versionandlaunchctl printoutput before matching or truncating it.scripts/macos-pkg.sh: same for thecodesign -dvprobe. A SIGPIPE there would skip the slice-signature check on a certificate-signed release.CI-only plus a release script, with no agent behavior change, so
skip-changelog.🤖 Generated with Claude Code