Repository navigation
Release 1.3.4 - security fixes. - #39
Merged
Merged
Conversation
A quoted url() whose target contained ', " or ) matched nothing in the old token regex, so the check returned true and off-document URLs survived in style/paint attributes (e.g. a root <svg> background that beacons the viewer's IP on every render). Count every url( opener and require each to be a strict #fragment ref; any mismatch drops the attribute. Adds regression tests for the quote/paren variants. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Defense-in-depth behind the SVG sanitizer and escapeHtml: the page may not load or send anything cross-origin (default-src 'none', img-src 'self' data: blob:, connect-src 'self'). style-src keeps 'unsafe-inline' for the innerHTML style="" attributes. The single-file build inlines its JS, so a post-generateBundle plugin appends the inline script's sha256 to script-src instead of allowing 'unsafe-inline' scripts; it fails the build if the CSP meta is missing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Security release: fail-closed url() check in the SVG sanitizer and a Content Security Policy for the page and the offline copy. Also picks up lucide-static ^1.47.0 (no shipped icon changed). Bump the version and add the 1.3.4 CHANGELOG section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 1.3.4 - security fixes. Maps render exactly as before.
', " or ) matched nothing in the old token regex, so off-document URLs
survived in style/paint attributes (e.g. a root background that
beacons the viewer's IP on every render). Every url( opener must now be a
strict #fragment ref; regression tests added for the quote/paren variants.
connect-src 'self'. The single-file build gets its inline script's sha256
appended to script-src at build time (no 'unsafe-inline' scripts).
(includes lucide-static 1.46.0 -> 1.47.0 from deps: bump lucide-static from 1.46.0 to 1.47.0 #37, no shipped icon changed)
Verified locally on Node 26.10.0: typecheck clean, 226 tests pass, npm audit 0,
build produces dist/download/netgraph.html. CSP checked in the dev server, the
web build (preview) and the offline copy over http and from disk - the planted
beacon is blocked, the example map renders, and Download Offline Copy works.
🤖 Generated with Claude Code