Repository navigation
fix: ids are now reset correctly for the next match statement - #111
Merged
Merged
Conversation
Owner
|
@d-u-d-e thanks for your contribution. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Bowen,
I discovered this elegant library, so I decided to take a look at it because I'd like to use it on my own projects.
I think there's an issue with
matchPatterns:processIdis called on aPatternPairstype, which in turn callsprocessIdImplonPatternTraitsfor aPatternPair, which has an emptyprocessIdImplas the primary template. ThusprocessId(pattern, 0, IdProcess::kCANCEL)has no effect. I added a test case that covers this issue. Without the changes, the secondmatchthrows. I don't think this should be expected behavior (but maybe I'm wrong).Do you agree on this? If you'd like me to open an issue let me know.
Hope you can find some time to look at this PR. Thank you!