VV: Write Image (ITK) fully V&V'ed - #1693
Open
JDuffeyBQ wants to merge 5 commits into
Open
Conversation
Signed-off-by: Jared Duffey <jared.duffey@bluequartz.net>
Signed-off-by: Jared Duffey <jared.duffey@bluequartz.net>
Signed-off-by: Jared Duffey <jared.duffey@bluequartz.net>
Signed-off-by: Jared Duffey <jared.duffey@bluequartz.net>
Summary: - Found and fixed 2 bugs (fill character validation and uint32/uint64 wrong type in case) - Documented 1 deviation from DREAM3D 6.5.171 (D1 default slice-index padding) - Retired 0 tests (none) - Augmented existing tests with 4 new test cases including a templated Class 1 (Analytical) + Class 4 (Invariant) oracle - Added V&V source-tree deliverables (report, deviations) - Updated wording in docs Signed-off-by: Jared Duffey <jared.duffey@bluequartz.net>
imikejackson
added a commit
to imikejackson/simplnx
that referenced
this pull request
Jul 28, 2026
Both remaining MTR closure gaps were authored on 2026-07-28 (BlueQuartzSoftware#1694 RequireMinNumNeighbors, BlueQuartzSoftware#1693 ITKImageWriter), taking the closure to 29/29 across all branches while develop still reports 18/29. * Record both PRs in section 1.1 with their oracle classes and state * Add a required decision on ITK removal versus the submission tag: BlueQuartzSoftware#1693 verifies ITKImageWriterFilter in the plugin slated for removal, which is correct only if the submission tags before ITK is dropped * Note that the BlueQuartzSoftware#1693 oracle fixture is format-agnostic and transfers to WriteImageFilter if the decision goes the other way * Rewrite Phase 1 as review-bound rather than effort-bound; authoring is done, what remains is the ITK decision, the merge backlog, PR BlueQuartzSoftware#1640, and backfilling oracle attestations * Promote the merge backlog to its own section: 13 of 39 reports exist only on unmerged branches and 11 of those are closure filters, so a release tag cut today would pin an incomplete evidence package * Require vv_status.py to report against a named git ref defaulting to develop, so the all-branch versus develop gap cannot be hidden * Refresh counts throughout: 39 reports authored, 26 on develop, MTR-adjacent 29 authored of 63 Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Naming Conventions
Naming of variables should descriptive where needed. Loop Control Variables can use
iif warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the filesimplnx/docs/Code_Style_Guide.mdfor a more in depth explanation.Filter Checklist
The help file
simplnx/docs/Porting_Filters.mdhas documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.Unit Testing
The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:
Code Cleanup