Skip to content

fix: harden Desktop wallet and agent boundaries - #133

Merged
KillerQueen-Z merged 1 commit into
mainfrom
fix/desktop-wallet-security
Aug 26, 2026
Merged

fix: harden Desktop wallet and agent boundaries#133
KillerQueen-Z merged 1 commit into
mainfrom
fix/desktop-wallet-security

Conversation

@KillerQueen-Z

Copy link
Copy Markdown
Collaborator

Summary

  • make Desktop workspace, shell, Detach, and Polymarket money approvals authoritative even with persisted CLI allow rules
  • canonicalize tool aliases and schema-coerce inputs before permission and TradePlan checks
  • disable paid prefetch in Desktop/hosted modes and enforce a non-bypassable hosted session spend ceiling
  • bind the packaged backend to an OS-assigned loopback port and hand the actual port to Electron over authenticated IPC
  • restrict local media serving to signed URLs, approved roots, and safe media types
  • fail closed for Jupiter and Base 0x live swaps until complete local transaction/EIP-712 validation exists; keep read-only quote tools available

Security rationale

Jupiter and 0x responses supplied transaction bytes, allowance spenders, or EIP-712 payloads that were signed locally without independently binding them to the exact approved asset movement. This patch prevents those signing paths from reaching wallet or network access.

Validation

  • npm test: 660/660 passed
  • Desktop typecheck: passed
  • Desktop lint: passed
  • Desktop production build: passed
  • macOS arm64 DMG packaging: passed
  • fail-closed regression tests cover direct calls with auto_approve:true and assert no network access

Security scan: one additional high-severity 0x transaction-integrity finding validated and remediated. Scan coverage was risk-prioritized/partial because TAC and fresh worker slots were unavailable.

@KillerQueen-Z
KillerQueen-Z merged commit e46df7c into main Aug 26, 2026
5 checks passed
@KillerQueen-Z
KillerQueen-Z deleted the fix/desktop-wallet-security branch August 26, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant