Repository navigation
refactor(openclaw): remove the bundled judge adapter - #93
Open
BitmapAsset wants to merge 3 commits into
Open
BitmapAsset wants to merge 3 commits into
BitmapAsset wants to merge 3 commits into
Conversation
The host validates the manifest schema before the plugin loads and rejects unknown keys. An old configuration that still set jevModel or jevKeyFile therefore stopped validating, although classifier "jev" and classifierShadow were already tolerated. Both options stay declared as deprecated no-ops with one load-time warning each; the key file is never read.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenClaw plugin shipped an optional provider-specific judge adapter, and public examples used a third-party model id. This removes the adapter and uses
example-judgethroughout the sample data, playground and assertions.Stacked on #92 (
feat/0.15-usability-1).auto(the host's configured decision model, else keywords) andkeyword. Legacyclassifier: "jev"still loads, warns once, and uses keywords without calling a model or network API.classifierShadow,jevModelandjevKeyFilestay declared in the manifest schema as deprecated no-ops with one load-time warning each. The host rejects unknown keys before the plugin loads, so this keeps an old configuration valid after the upgrade. The key file is never read. The destructive-action and senses shadow modes are unchanged. The host decision model now supplies the urgency question; keyword-only time pressure requires the existing opt-in heuristic settings.Validation on the host (macOS arm64, Node 26.12.1, Python 3.14, Cargo 1.98.1):
npm testat 63906b0: 152/152 (160 previously: 18 tests removed with the adapter file, 4 generic tests retained, 6 migration/host tests added).jevModelorjevKeyFilewere rejected; 63906b0 fixes that.python3 python/test_probbit.pyat 63906b0: 16/16.cargo test --offline --workspaceat 9bb8b1a: 477 passed, 0 failed, 4 ignored (36 test binaries). 63906b0 touches no Rust.git diff --checkpass at 63906b0.Known and not changed here: two plugin tests that spawn a stand-in binary under the hook's 500 ms budget ("safety: a binary that refuses the event" and "hook, a binary with --label") can time out on a busy machine. The test file is untouched by this PR. At 63906b0 the first run failed both and the next four consecutive runs were clean; at 9bb8b1a six consecutive runs were clean and two earlier runs each failed one of the two.
Remaining adapter-name references are the removal changelog, the legacy-config migration handling and its tests, and incidental byte matches in unchanged compressed media. Benchmark sources under
bench/and format-provenance attribution are intentionally unchanged; BENCHMARKS.md and REPRODUCE.md now point tobench/agentdojo/README.mdfor the API route the benchmark used.