Inventory Studio W4: Shop-pin node: specifier gate - #129
Merged
BitcoinErrorLog merged 5 commits intoSep 28, 2026
Merged
Conversation
The browser entry of @bitcoinerrorlog/pubky-shop and a production client bundle must not quote a Node builtin specifier. Putting that import back fails the check.
The Shop pin gate rejects a caret range. The release branch declared ^0.1.6.
BitcoinErrorLog
force-pushed
the
cursor/inventory-studio-w4-dfb2
branch
from
September 28, 2026 19:10
6b7c242 to
3651e01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inventory Studio W4 proof is already on
release/shop-v0.6.8(merged Shop #87, tagsshop-v0.6.20throughshop-v0.6.32). This branch adds the missing regression for the Shop pin: the@bitcoinerrorlog/pubky-shop.browser entry, and the production client bundle when.next/staticis present, must not quote a Node builtin specifier.@bitcoinerrorlog/pubky-shop@0.1.5(exact, lockfile match).browser_node_specifiers=0, no external imports,./nodeis not imported from Shopsrc.npm run build(next build --webpack) exit 0. Client JS: 381 files,static_quoted_node_specifiers=0. A substring search fornode:hits 15 files; those are{node:keys, not builtin imports.import "node:fs"on the browser entry makes the script exit 1. Restoring it exits 0.src/test/live/inventory-w4.live.tsand the Dexie table wipe infranky.inventory-studio.test.tsare unchanged and were not run against staging.Kimi is for the coordinator. No deploy.
Test plan
node scripts/shop-pin-node-grep.mjs --require-staticafternpm run buildprintsstatic_quoted_node_specifiers=0npx vitest run --project unit src/core/services/marketplace/shop-pin-node-grep.test.tsscripts/prepush.shlast line isPREPUSH OK