Remove the TypeScript/WASM package - #132
Conversation
The TypeScript client now lives in BitBoxSwiss/bitbox-api-ts. Remove the WASM bindings, feature, serialization adapters, browser transports, sandbox, and package build and CI tooling. Drop WASM size optimizations and unused dependencies, and regenerate the protobuf code without WASM attributes. - Move Bitcoin's base64 feature to dev-dependencies for the PSBT example. - Remove U2FFraming and the unused Default implementation, retaining the U2fHid encoding and decoding methods used by physical devices and simulators. - Move the vendor and product IDs into usb.rs and remove the constants module. - Inline the private BitBox::from constructor into from_transport. Consolidate the Rust and repository documentation in README.md, rename the Rust changelog to CHANGELOG.md, and document the breaking changes for Rust consumers. Refs: BitBoxSwiss#60
There was a problem hiding this comment.
Concept ACK
What do you plan doing with showMnemonic(), changePassword(), and bip85AppBip39(), which are currently stubs in the new package?
Are you planning to document the migration? The corrected declarations can break existing TS code.
Also, let json = serde_json::to_string(&signature)?; would not be possible anymore. Wouldn't it make sense to keep it here?
See BitBoxSwiss/bitbox-api-ts#11
Which corrected declarations? If you mean UInt8Array for sigs, that was mistyped in this repo and it does not seem to cause an issue, we already had some migrate to the new lib without issues.
Not sure, could check some users of this lib, but I doubt it will be a big issue. It's a at most a small breaking change and the lib is on version |
|
Thanks!
Good to hear, still, it depends on the implementation. A caller assigning
ACK |
The TypeScript client now lives in BitBoxSwiss/bitbox-api-ts.
Remove the WASM bindings, feature, serialization adapters, browser transports,
sandbox, and package build and CI tooling. Drop WASM size optimizations and
unused dependencies, and regenerate the protobuf code without WASM attributes.
encoding and decoding methods used by physical devices and simulators.
Consolidate the Rust and repository documentation in README.md, rename the Rust
changelog to CHANGELOG.md, and document the breaking changes for Rust consumers.
Refs: #60