Repository navigation
fix: read-only error for derive_label/add_table on a read-only container - #285
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…-only # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #279.
derive_labelandadd_tableon a container opened withmode="r"that has nolabels/tablesgroup raisedNgioValidationError("No labels found in the image."): the group could not be created, and the error said it did not exist. Both now raiseNgioValueError("The group is read only. Cannot derive a label.")/... add a table.first, matching the other write paths. Same check onOmeZarrPlate.add_table.The read path is unchanged:
list_labelsreturns[]andlabels_containerstill raises "No labels found" on a read-only container.Checklist before merging
CHANGELOG.md🤖 Generated with Claude Code