Repository navigation
fix: π StrictMode socket state and CLI startup crash - #143
Merged
Merged
Conversation
β¦ in StrictMode StrictMode runs mount, cleanup and mount again. Hooks guarded with a mount-once check lost their subscriptions on the cleanup and never got them back, so connected from useListener and useEmitter stayed false. Closes #140 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The bundle was built for the browser, so fs, path and other builtins were replaced with an empty stub and the cli crashed on startup. Also fixes the bin entry, --help and --version, and adds a spec that builds the package and runs the output with node. Closes #142 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
π This PR is included in version 9.0.1 π The release is available on: Your semantic-release bot π¦π |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two open issues and adds tests so neither can come back quietly.
StrictMode: `connected` stuck on `false` (closes #140)
StrictMode runs mount, cleanup and mount again. `useSocketState` subscribed to connection events behind a mount-once guard, so the cleanup removed the subscriptions and the guard stopped them from coming back.
CLI crash on startup (closes #142)
Not specific to Node 24. The CLI was built for the browser, so Vite swapped `fs`, `path` and other builtins for an empty stub. Reproduced with the published 9.0.0.
Tests
Full suites pass locally: react 428, cli 32. Lint and typecheck are clean for both packages.
π€ Generated with Claude Code