Docker stack improvements#90
Merged
Merged
Conversation
danschmidt5189
commented
Jul 16, 2026
danschmidt5189
commented
Member
- Corrects asset handling within the Dockerfile.
- Commits yarn.lock and makes yarn builds immutable.
- Adds a Compose "updater" service to handle bootstrapping.
- Removes redundancies from the Dockerfile.
danschmidt5189
force-pushed
the
AP-799-3
branch
5 times, most recently
from
July 16, 2026 18:20
3458bbe to
9afca67
Compare
danschmidt5189
marked this pull request as ready for review
July 16, 2026 18:41
awilfox
approved these changes
Jul 16, 2026
awilfox
left a comment
awilfox
left a comment
Member
There was a problem hiding this comment.
r+. Thanks for fixing this (you may want to reference AP-779 instead of AP-799).
| needs: docker-build | ||
| env: | ||
| COMPOSE_FILE: docker-compose.yml:docker-compose.ci.yml | ||
| COMPOSE_FILE: compose.yml:compose.ci.yml |
Member
There was a problem hiding this comment.
Is this something we are(/should be) doing in other repositories as well? Right now, this doesn't match any convention we have.
Member
Author
There was a problem hiding this comment.
Yes but I'd say just on a "best effort" basis. It's Compose's new default but the old docker-compose.yml still works.
| apt-get install -y --no-install-recommends \ | ||
| bash \ | ||
| curl \ | ||
| default-jre-headless \ |
Member
Author
There was a problem hiding this comment.
It was a good catch! 👏
- Yarn / Asset handling - Commits yarn.lock and makes installs immutable. - Installs yarn 1.22.22 specifically (instead of just "stable"). - Removes redundant asset precompilation steps. - Compose Improvements - Adds an "updater" service to handle bootstrapping. - Switches to preferred "compose.yml" naming convention. - Misc. - Fixes zeitwork loading issue with GeoDataHealthCheck. - Adds smoke tests to the final Dockerfile stage.
Member
Author
|
I've amended the commit title to reference AP-779. I'll merge once this goes green. Thanks for the review @awilfox! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.