Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing grave markers after restart currently move otherwise active saved graves into the broken list, and restoring a broken grave can leave its in-memory removal flag set. This restores active markers only in air/fluid blocks and resets the broken-grave state when an administrator restores it. Scheduled writes recheck removal state and material, so automatic repair cannot replace a solid block or resurrect a removed grave.
CHEST-mode list icons now avoid player-profile lookups. Startup cleanup avoids directly accessing the legacy-unavailable ITEM_DISPLAY enum field, and legacy item-map loading accepts different map implementations and numeric string slot keys. Startup expiry is applied after active-list insertion so expired records are not added back afterward.
Validation: fresh read-only source review approved the exact implementation; JDK 21 clean Maven package passed 13 tests with zero failures/errors/skips. The shaded JAR contains the expected descriptor/resources/entry point and relocated AdvancedCore, with no test libraries. Diff checks pass.
This focused draft is based on main and must be reconciled separately with the broader lifecycle work in #84. No serialization format, schema, command or permission changes are included. Existing explicit admin same-location restoration behavior remains. The item GUI remains view-only, and stored PLAYER_HEAD markers can still request profiles. Live water/restart, offline-profile throttling and old-server behavior have not been reproduced; broad claim durability, unavailable-world handling and the separate armour/offhand serializer defect remain outside scope.
Refs #79, #78, #62, #47. These references do not claim complete reproduction or resolution of every reported symptom.