Skip to content

Restore missing grave markers and broken-grave state - #93

Draft
BenCodez wants to merge 3 commits into
mainfrom
fix/grave-recovery-restart
Draft

BenCodez wants to merge 3 commits into
mainfrom
fix/grave-recovery-restart

Conversation

@BenCodez

Copy link
Copy Markdown
Owner

Missing grave markers after restart currently move otherwise active saved graves into the broken list, and restoring a broken grave can leave its in-memory removal flag set. This restores active markers only in air/fluid blocks and resets the broken-grave state when an administrator restores it. Scheduled writes recheck removal state and material, so automatic repair cannot replace a solid block or resurrect a removed grave.

CHEST-mode list icons now avoid player-profile lookups. Startup cleanup avoids directly accessing the legacy-unavailable ITEM_DISPLAY enum field, and legacy item-map loading accepts different map implementations and numeric string slot keys. Startup expiry is applied after active-list insertion so expired records are not added back afterward.

Validation: fresh read-only source review approved the exact implementation; JDK 21 clean Maven package passed 13 tests with zero failures/errors/skips. The shaded JAR contains the expected descriptor/resources/entry point and relocated AdvancedCore, with no test libraries. Diff checks pass.

This focused draft is based on main and must be reconciled separately with the broader lifecycle work in #84. No serialization format, schema, command or permission changes are included. Existing explicit admin same-location restoration behavior remains. The item GUI remains view-only, and stored PLAYER_HEAD markers can still request profiles. Live water/restart, offline-profile throttling and old-server behavior have not been reproduced; broad claim durability, unavailable-world handling and the separate armour/offhand serializer defect remain outside scope.

Refs #79, #78, #62, #47. These references do not claim complete reproduction or resolution of every reported symptom.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a5360c92-8337-4d81-8c7a-cc9956486ea2
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants