wheels: drop --retry-all-errors, too new for AlmaLinux 8's curl - #131
Merged
Conversation
My own mirror fix broke the Linux wheels a different way:
curl: option --retry-all-errors: is unknown
--retry-all-errors landed in curl 7.71.0; manylinux_2_28 is AlmaLinux 8,
whose curl is 7.61. I "verified the command end to end" on macOS, whose
curl is current -- proving nothing about the curl that actually runs it.
Replaced with --retry-connrefused (7.52.0), which covers the failure mode
that mattered. Every flag now used is 7.52 or older:
--retry 7.12.3
--retry-connrefused 7.52.0
--connect-timeout 7.7
Checked against `Added:` in curl/docs/cmdline-opts/<opt>.md, and recorded
as a CURL FLAG CEILING comment beside the command so the next person does
not repeat it. Verified the folded scalar still parses to one line with
no stray newlines and no banned flag.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The mirror fix in #130 broke the Linux wheels a different way:
--retry-all-errorslanded in curl 7.71.0. manylinux_2_28 is AlmaLinux 8, whose curl is 7.61.I claimed to have "verified the command end to end" — but I ran it on macOS, whose curl is current. That proved nothing about the curl that actually executes it inside the container.
Fix
Replaced with
--retry-connrefused(7.52.0), which covers the failure mode that mattered. Every flag now used is 7.52 or older:--retry--retry-connrefused--connect-timeoutChecked against
Added:incurl/docs/cmdline-opts/<opt>.md, not from memory.Recorded as a CURL FLAG CEILING comment beside the command so this does not recur.
Verified
--retry-all-errorsstrings left are in the warning comment['--connect-timeout', '--prefix', '--retry', '--retry-connrefused']Note this still cannot be proven before merge:
wheels.ymlonly runs on tags, and there is no container runtime here to test the real image against.🤖 Generated with Claude Code