Skip to content

wheels: drop --retry-all-errors, too new for AlmaLinux 8's curl - #131

Merged
revarbat merged 1 commit into
mainfrom
fix-wheels-curl-flag
Aug 28, 2026
Merged

wheels: drop --retry-all-errors, too new for AlmaLinux 8's curl#131
revarbat merged 1 commit into
mainfrom
fix-wheels-curl-flag

Conversation

@revarbat

Copy link
Copy Markdown
Member

Problem

The mirror fix in #130 broke the Linux wheels a different way:

curl: option --retry-all-errors: is unknown

--retry-all-errors landed in curl 7.71.0. manylinux_2_28 is AlmaLinux 8, whose curl is 7.61.

I claimed to have "verified the command end to end" — but I ran it on macOS, whose curl is current. That proved nothing about the curl that actually executes it inside the container.

Fix

Replaced with --retry-connrefused (7.52.0), which covers the failure mode that mattered. Every flag now used is 7.52 or older:

flag Added
--retry 7.12.3
--retry-connrefused 7.52.0
--connect-timeout 7.7

Checked against Added: in curl/docs/cmdline-opts/<opt>.md, not from memory.

Recorded as a CURL FLAG CEILING comment beside the command so this does not recur.

Verified

  • Parsed YAML value contains 0 newlines (the folded-scalar trap from wheels: fetch bison from a mirror, not only ftp.gnu.org #130 still holds)
  • No banned flag in the command — the only two --retry-all-errors strings left are in the warning comment
  • Flag set asserted programmatically: ['--connect-timeout', '--prefix', '--retry', '--retry-connrefused']

Note this still cannot be proven before merge: wheels.yml only runs on tags, and there is no container runtime here to test the real image against.

🤖 Generated with Claude Code

My own mirror fix broke the Linux wheels a different way:

    curl: option --retry-all-errors: is unknown

--retry-all-errors landed in curl 7.71.0; manylinux_2_28 is AlmaLinux 8,
whose curl is 7.61. I "verified the command end to end" on macOS, whose
curl is current -- proving nothing about the curl that actually runs it.

Replaced with --retry-connrefused (7.52.0), which covers the failure mode
that mattered. Every flag now used is 7.52 or older:

    --retry             7.12.3
    --retry-connrefused 7.52.0
    --connect-timeout   7.7

Checked against `Added:` in curl/docs/cmdline-opts/<opt>.md, and recorded
as a CURL FLAG CEILING comment beside the command so the next person does
not repeat it. Verified the folded scalar still parses to one line with
no stray newlines and no banned flag.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@revarbat
revarbat merged commit 1fff9e2 into main Aug 28, 2026
3 checks passed
@revarbat
revarbat deleted the fix-wheels-curl-flag branch August 28, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant