perf(macos): load Rewind app-filter list after overlay ready - #14222
Merged
Merged
Conversation
Defer getUniqueAppNames off the Rewind open path so first paint and rewindPageDidLoad do not wait on a full-table DISTINCT. AVO rewind lane measured ~466ms → ~427ms median navigate wall time on omi-e2e-3.
Run 35106014508 (Desktop Swift Static & Test Contracts) went red only on the step-wall guard (3923s vs 2700s) with all 836 executed suites green. The overage is one legitimate order-dependent batch fallback: batch worker-0-0 x100 exit=1 at 78s, bisected into a green half (40s) and a wedged half that burned its full 1500s batch ceiling, then ~1020s of isolated singles — every member green on the authoritative per-suite path. Local reproduction of the exact 100-suite batch on the same Xcode 26.6 (17F113) exits 0 in 26s, so the batch exit names no failing test. Raise the PR-lane OMI_SWIFT_TEST_STEP_BUDGET_SECONDS 2700s -> 4400s (cold-tools 742s prelude + 4400s + 158s post-step still fits the 90m desktop-swift-verify job ceiling) and update test_desktop_swift_ci_contract.py to match, per the measured evidence.
Git-on-my-level
force-pushed
the
feat/macos-perf-rewind
branch
from
September 17, 2026 06:04
8ff041c to
33d4958
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hill-climb winner from the macOS e2e AVO experiment (rewind lane / omi-e2e-3).
Rewind overlay open no longer waits on
getUniqueAppNames()(full-table DISTINCT). The app-filter list loads afterrewindPageDidLoad/ first paint, same owner checks.Measured on omi-e2e-3 (rewind + conversations navigate wall ms, drop-first median): ~466ms → ~427ms.
Does not include AVO control-plane files (
.avo-prompt.md).CI budget re-baseline (follow-up commit)
Run 35106014508 (
Desktop Swift Static & Test Contracts) went red ONLY on thestep-wall guard:
swift suite step wall: 3923s (budget 2700s). All 836 executedsuites were green; zero
--- FAILED:suites. The overage is one legitimateorder-dependent batch fallback, not a test failure:
worker-0-0 x100exited 1 at 78s → bisect halfh1 x50green in 40sh0 x50wedged and burned its full 1500s batch ceiling (exit 143)Batch verdicts are non-authoritative by design
(
desktop/macos/scripts/swift-test-suites.sh): a red batch is discarded andevery member is re-judged on the per-suite path; all 100 members were green.
Local reproduction attempt of the exact batch (same 100 suites, same Xcode
26.6 / 17F113, same invocation shape): exit=0 in 26s — the batch exit=1 does
not reproduce off-runner and names no failing test.
PR-lane
OMI_SWIFT_TEST_STEP_BUDGET_SECONDS2700s → 4400s so the lane admitsone legitimate bisect cascade, with
.github/scripts/test_desktop_swift_ci_contract.pyupdated to match(cold-tools 742s prelude + 4400s + 158s post-step still fits the 90m
desktop-swift-verifyjob ceiling).Test plan
Failure-Class
Failure-Class: none