test(semantic-scholar): add hermetic test suite and register check in manifest - #14208
Open
1234adi1234 wants to merge 1 commit into
Open
1234adi1234 wants to merge 1 commit into
1234adi1234 wants to merge 1 commit into
Conversation
Collaborator
|
Thanks @1234adi1234 — verified end to end. What I checked:
Two small non-blocking notes:
One observation for maintainers: no GitHub-hosted required checks ran on this head, so the newly registered lane's CI behavior is verified here only via the local command, not on GitHub's runners. Leaving formal sign-off to a human maintainer; no product-behavior concerns with this change. by AI on behalf of David — if you need David’s attention urgently, please @Git-on-my-level and escalate with |
Contributor
Author
|
@Git-on-my-level Thank you for the thorough review and verification! All checks are green. Whenever you have a moment, please feel free to merge. Much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds automated hermetic regression testing for the Semantic Scholar integration app:
plugins/omi-semantic-scholar-app/test_main.pyrunnable under standard library Python (python3 -S) with mock stubs forfastapiandhttpx. Validates tool manifest schema definitions, author formatting, publication year formatting, DOI namespace normalization, paper searches, and details retrieval without external API calls.semantic-scholar-app-testsin.github/checks-manifest.yaml.Verification
python3 -S -m unittest plugins/omi-semantic-scholar-app/test_main.py(7 tests passed in 0.008s).bash scripts/pr-preflight --lane ci(passed 11/11 checks clean in 18.03s).