Fix local inference prompt truncation, tool calls, and memory recovery

biorouter-self-test.yaml

@@ -23,6 +23,7 @@ activities:
   - Test error boundaries and security controls
   - Validate the Settings reset contract and its active-work safety gate
   - Verify provider error handling, conversation-scoped reasoning, and saved-credential deletion safeguards
+  - Verify local inference executes tools and preserves results across turns
   - Validate Crew empty-state onboarding, isolated Alice/Bob/Carol development profiles, and private-by-default workspace presentation
   - Exercise Crew first-host preparation and SSH trust validation with synthetic invitation metadata only
   - Verify Crew request idempotency, human-only session access, and scoped normal-chat tool denial paths
@@ -36,7 +37,7 @@ parameters:
     input_type: string
     requirement: optional
     default: "all"
-    description: "Which test phases to run: all, basic, extensions, computer_use, crew, apps, previews, subagents, knowledge, workflows, reset, providers, office, advanced"
+    description: "Which test phases to run: all, basic, extensions, computer_use, crew, apps, previews, subagents, knowledge, workflows, reset, providers, local_inference, office, advanced"
 
   - key: test_depth
     input_type: string
@@ -893,6 +894,27 @@ prompt: |
   Log results to: {{ workspace_dir }}/phase4c_provider_boundaries.md
   {% endif %}
 
+  {% if test_depth != "fixture_only" and (test_phases == "all" or "local_inference" in test_phases) %}
+  ## PHASE 4D: Local Inference Tool Execution
+
+  Run this phase only when the harness has selected an approved local Ollama or Llama Server
+  model. Otherwise report BLOCKED. Keep the selected provider, model and settings unchanged.
+  Work only in {{ workspace_dir }}/local-inference/. Do not build the repository, download
+  models, inspect credentials, or change the user's Ollama daemon settings.
+
+  1. Use a real tool to create factorial.py in that directory. It must print math.factorial(10).
+     Execute the saved file, require exit 0 and stdout exactly 3628800, then read it back.
+  2. Create notes.txt containing exactly these lines: urine, plasma, URINE, serum, urine,
+     saliva, Urine, tissue, urine. Count case-insensitive whole-word matches using a tool.
+     Require exactly 5 and identify the saved file in the answer.
+  3. Read notes.txt again in a later tool call and independently verify the same count.
+     A description of a command, invented tool name, or JSON displayed instead of a real
+     tool result is FAIL. Record the tool names and actual results.
+  4. Write phase4d_local_inference.md with PASS or FAIL for each assertion and any observed
+     provider error. Do not claim a context window or memory measurement that was not
+     exposed by the harness. The external verifier checks the saved scripts and outputs.
+  {% endif %}
+
   ## 📊 PHASE 5: Final Report Generation
 
   {% if test_depth == "fixture_only" %}

crates/biorouter-cli/src/cli.rs

@@ -1119,14 +1119,18 @@ enum LocalModelCommand {
     /// Download a local model into the shared cache without starting a chat
     #[command(about = "Download (pre-cache) a local model")]
     Pull {
-        #[arg(help = "Catalog model name (e.g. qwen3.5-4b) or a raw owner/repo:QUANT HF spec")]
+        #[arg(
+            help = "Catalog model name (qwen3.8-27b or gemma4-31b) or a raw owner/repo:QUANT HF spec; a retired catalog name downloads the model a chat naming it runs"
+        )]
         model: String,
     },
 
     /// Delete a downloaded local model to reclaim disk space
     #[command(about = "Delete a downloaded local model", visible_alias = "delete")]
     Rm {
-        #[arg(help = "Catalog model name (e.g. gemma4) or a raw owner/repo:QUANT HF spec")]
+        #[arg(
+            help = "Catalog model name (e.g. qwen3.8-27b), a retired catalog name (e.g. gemma4) to free the files it left, or a raw owner/repo:QUANT HF spec"
+        )]
         model: String,
     },
 }
@@ -3857,3 +3861,65 @@ mod default_max_turns_tests {
         );
     }
 }
+
+#[cfg(test)]
+mod local_model_help_tests {
+    use super::Cli;
+    use biorouter::providers::llamacpp::{MODEL_CATALOG, RETIRED_MODELS};
+    use clap::CommandFactory;
+
+    fn model_arg_help(subcommand: &str) -> String {
+        let mut command = Cli::command();
+        let local = command
+            .find_subcommand_mut("models")
+            .and_then(|models| models.find_subcommand_mut("local"))
+            .expect("`biorouter models local` exists");
+        let sub = local
+            .find_subcommand_mut(subcommand)
+            .unwrap_or_else(|| panic!("`biorouter models local {subcommand}` exists"));
+        let help = sub
+            .get_arguments()
+            .find(|arg| arg.get_id() == "model")
+            .and_then(|arg| arg.get_help())
+            .map(|help| help.to_string());
+        help.unwrap_or_else(|| panic!("`{subcommand}` has a model argument with help"))
+    }
+
+    /// `pull`'s help named `qwen3.5-4b` through two catalog changes: an example
+    /// that, followed, downloaded a model no chat would run. It must name only
+    /// models the catalog offers, and the clap `help` string cannot read the
+    /// catalog itself, so this keeps the literal honest.
+    #[test]
+    fn pull_help_names_the_catalog_and_no_retired_model() {
+        let help = model_arg_help("pull");
+        for entry in MODEL_CATALOG {
+            assert!(help.contains(entry.name), "{help}");
+        }
+        for retired in RETIRED_MODELS {
+            let named = help
+                .split(|c: char| c.is_whitespace() || "(),;".contains(c))
+                .any(|word| word == retired.name);
+            assert!(!named, "pull help names retired {}: {help}", retired.name);
+        }
+    }
+
+    /// `rm` may name a retired model (deleting its files is what it is for), but
+    /// its first example must be a model the catalog offers.
+    #[test]
+    fn rm_help_leads_with_a_catalog_model() {
+        let help = model_arg_help("rm");
+        let first_catalog_name = MODEL_CATALOG
+            .iter()
+            .filter_map(|entry| help.find(entry.name))
+            .min()
+            .expect("rm help names a catalog model");
+        let first_retired_name = RETIRED_MODELS
+            .iter()
+            .filter_map(|retired| help.find(&format!("e.g. {}", retired.name)))
+            .min();
+        assert!(
+            first_retired_name.is_none_or(|at| first_catalog_name < at),
+            "{help}"
+        );
+    }
+}