Repository navigation
fix(test): race-aware sizing for two timing-sensitive tests - #332
Merged
Merged
Conversation
TestRED_RedactCredentialNamesScaleLinearly applied its 1 MiB wall-clock budget under -race, and TestRED_RunsFinishedRunPinsAgentAndSession built a 6 MiB session under -race although its heap check is skipped there. Both failed the documented 'go test -race ./... -count=1' locally. Follow the existing raceEnabled pattern; non-race runs keep the full checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
odek | 0d30062 | Commit Preview URL Branch Preview URL |
Oct 18 2026, 12:16 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Locally,
go test -race ./... -count=1(the command in AGENTS.md) failed two tests every time, onmainas well. CI did not catch it because it runs with-short.internal/redactTestRED_RedactCredentialNamesScaleLinearly-race, which is 5–10× slower!raceEnabled && !testing.Short()), the same guard used inredhunt_2026_10_12b_final_test.go. The 64→256 KiB linear-scaling check still runs under race.cmd/odekTestRED_RunsFinishedRunPinsAgentAndSession-race, though the heap check that needs it is skipped under race. Each run took more than the 60s wait.-shortsize under race too. The structural no-pinning check still runs in every mode, and the heap check runs without race at full size.Without race, both tests check exactly what they did before.
Test plan
-raceand without.go test -race ./... -count=1 -timeout 900spasses in full locally.go vet,gofmt🤖 Generated with Claude Code