Repository navigation
fix(ci): serve drain race and danger test timeout - #330
Merged
Merged
Conversation
handleWS registered in a sync.WaitGroup that the shutdown drain waits on. A handler starting while a drain still waits (a second serve instance in the same process, as the test suite runs them) is an add-from-zero concurrent with Wait, which the race detector reports and failed TestRED_WSQueuedMessagesAreByteBounded on CI. A mutex-guarded live counter orders both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ut headroom internal/danger took 350-600s under -race on CI (identical code, runner variance) against the default 10m test timeout. The prefilter equivalence check and the compound wrapping monotonicity check were 170s of a 390s local run; they now run as parallel shards (390s -> 258s). The test job also passes -timeout 20m so runner variance cannot fail a green suite. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
odek | 0ae630c | Commit Preview URL Branch Preview URL |
Oct 17 2026, 08:07 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two failures that turned the
testjob red onmainafter #328.TestRED_WSQueuedMessagesAreByteBounded.handleWSregistered in async.WaitGroupthat the shutdown drain waits on. A handler starting while an earlier drain still waits is an add-from-zero concurrent withWait, which the race detector reports. A mutex-guarded live counter (liveCounter) replaces it;TestLiveCounter_*covers concurrent add/wait (the same shape on aWaitGroupfails under-race) and wait-until-last-done.internal/danger10m timeout. The package took 350–600s under-raceon CI for identical code. The two slowest checks (prefilter equivalence, compound wrapping monotonicity) run as parallel shards: 390s → 258s locally. The test job passes-timeout 20mfor runner variance.🤖 Generated with Claude Code