Repository navigation
test(sdkharness): lock.legal_hold accepts real B2's 401 access_denied - #645
Draft
sophiecarreras wants to merge 1 commit into
Draft
sophiecarreras wants to merge 1 commit into
sophiecarreras wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lock.legal_holdconformance check now accepts what real B2 answers when a file version under a legal hold is deleted:401with codeaccess_denied.Real B2 was measured on 2026-11-10 and answers
401 access_denied. Until now the check accepted only the codes the standalone simulator used to return, so a simulator that matches real B2 made the check fail.Unauthorizedis accepted only when its code isaccess_denied. A bad or expired token (InvalidAuthToken), any otherUnauthorizedcode, a successful delete, 404, 5xx and network errors still fail.test/unit/test_sdkharness_lock_refusal.pycovers the new leaf: red before the change, 30 passed after; accepting anyUnauthorizedmakes 5 of them fail.Only test-harness files change; no library code.