Repository navigation
fix: seven bugs found in a whole-branch review, each with a failing-before test - #637
Merged
Merged
Conversation
…t that fails without the fix Fixes found by reviewing the default branch, with covering unit tests (fail before, pass after) and strengthened weak tests: - SQLite account info: bound parameter for allowed capabilities; reset upload pools after schema update - Bucket.copy: pass expires and content headers through - start_large_file: send customUploadTimestamp under its wire name - Replication monitor: no hang when the consumer fails - Local folder scan: keep scanning after an unreadable file when no reporter is given - Synchronizer: accept reporter=None - Parallel downloader: hash written data; surface writer errors One known bug whose behavior needs an owner decision (executor not shut down when scheduling fails) is recorded as an xfail with its reason. Also adds a sdkharness sync leg for reporter=None. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Seven bug fixes found by reviewing the whole default branch, each with a unit test that fails without the fix, plus strengthened versions of tests that could not fail. One known bug that needs a behavior decision is recorded as an
xfailwith its reason.Fixes:
allowedas a parameter; reset upload pools after a schema update.Bucket.copy: passexpires,content_disposition,content_encodingandcontent_languagethrough.start_large_file: sendcustomUploadTimestampunder its wire name.Synchronizer.sync_folders: acceptreporter=None.Also adds an sdkharness sync leg for
reporter=None. Changelog fragments are included (changelog.d/+*.fixed.md).Open question for the owners
Synchronizerdoes not shut its executor down when scheduling fails, so queued actions keep running. Whether to wait for them or cancel them is a behavior choice, so it is anxfailhere, not a fix.How this was checked
pytest test/unit: 961 passed, 64 skipped, 1 xfailed.ruff checkandruff format --checkclean on changed files.🤖 Generated with Claude Code