Repository navigation
Report "Checksum matches" only after download verification; strengthen unit tests - #1197
Draft
sophiecarreras wants to merge 1 commit into
Draft
sophiecarreras wants to merge 1 commit into
sophiecarreras wants to merge 1 commit into
Conversation
…ngthen unit tests - `file download` prints "Checksum matches" after the data has been saved and verified, and not at all with --skip-hash-verification (previously it was printed before the download and even when verification was skipped). - Unit-test harness: the autouse _TqdmCloser.__exit__ mock returned a truthy MagicMock, which swallowed every exception raised by a command that uses a progress bar. It now returns None; two tests that relied on the swallowing suppress the expected KeyError explicitly. - New or strengthened unit tests: rm by file id (hide marker and version), incremental upload, --destination-server-side-encryption on the wire, unbound-stream --part-size, sync thread options, sdkharness health and conformance negative paths, camelCase rejection in v4, download-file-by-name flags, rm progress, arg-parser and sdkharness file-lifecycle coverage. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
sophiecarreras
requested review from
eduardo-pavez-backblaze,
ffumero2003 and
goanpeca
November 2, 2026 15:14
Contributor
Author
|
Review request from Sofia (drafted with Claude). Nothing in this review has been checked by a human yet; the numbers come from an agent review of whole
This PR: Snyk Code reports one new issue that is not yet identified (someone with Snyk access needs to open it). 6 to 8 tests in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file downloadprinted "Checksum matches" before the download completed, and even with--skip-hash-verification. It now prints after the data is saved and verified, and never when verification is skipped._TqdmCloser.__exit__returned a truthy MagicMock, which silently swallowed exceptions from any command using a progress bar. It now returns None. Two tests that depended on the swallowing now suppress the expected KeyError explicitly.--part-size, sync thread options, sdkharness health and conformance negative paths, camelCase rejection in v4, download-file-by-name flags, rm progress, arg-parser and sdkharness file-lifecycle coverage.Test plan
pytest test/unit: 621 passed, 6 failed. The 6 are intest_autocomplete_cache.pyand fail identically on the unmodified base in my environment; I did not investigate the cause.ruff checkandruff format --checkpass on the changed files. Integration tests (need B2 credentials) were not run.🤖 Generated with Claude Code