Add Russian translation - #116
Open
igorekRnd wants to merge 1 commit into
Open
Conversation
Move the remaining hardcoded user-facing strings into resources first, otherwise they would stay English regardless of the locale: - `toDelta()`, which renders relative timestamps on the History screen, becomes `@Composable` and reads plurals instead of building English strings by appending "s"; - the ACRA crash dialog texts; - notification channel names and descriptions, which are visible in the system notification settings. Declare `locales_config.xml` so the app language can be picked independently of the system one on Android 13 and above.
Owner
|
Thanks for your contribution. Please do split the PR so both enhancements can be reviewed separately. |
Owner
|
I've gone through this PR as well as your other PRs. I request you to please read through the Contribution Guidelines and confirm compliancy with it. |
Author
|
Thanks for the answers. This code was generated by the Claude Code AI under my supervision. This means I'll be the only one using these changes. Thank you for a great app! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
values-rufor the whole UI, plus the helper app's name;locales_config.xmlandandroid:localeConfig, so the app language can be chosen independently of the system one on Android 13 and above;toDelta(), which renders relative timestamps on the History screen, becomes@Composableand reads plurals instead of building English strings by appendings;The crash report mail subject is deliberately left in English, as it is read by you rather than by the user.
If you would rather review the string extraction separately from the translation itself, I am happy to split this into two PRs.