Repository navigation
Read the licence policy from main and exempt the Sentry CLI - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependency review's licence allow-list lived inside
shared-checks.yml, so callers received it through their release pin: every newly allowed licence meant a release here and a Renovate PR in each caller before a blocked PR could merge..github/dependency-review.yml, which theDependenciesjob reads frommain. A change applies to every caller as soon as it merges, and re-running a failedChecks / Dependenciespicks it up. The workflow code itself stays pinned by release.allow-dependencies-licensesfor packages whose licence the policy excludes but whose use here it permits. The first entry ispkg:npm/sentry, the FSL-1.1-Apache-2.0 Sentry CLI that@sentry/bundler-plugins11.12 runs at build time.Licence policyjob runs the dependency review with each pull request's version of the file, so an invalid licence ID or broken YAML fails here instead of in every caller.docs/workflows.mdand CLAUDE.md describe the exception to the release rule. The file's path and themainbranch name are now part of the shared checks' interface.Callers pick this up with the next release's pin. From then on, licence changes need no release.