Skip to content

test(ci): probe whether a dataset-only change triggers ci-versioning - #351

Closed
sakanni wants to merge 1 commit into
developfrom
internal-tickets-#44-ProbeDatasetOnlyTrigger
Closed

sakanni wants to merge 1 commit into
developfrom
internal-tickets-#44-ProbeDatasetOnlyTrigger

Conversation

@sakanni

@sakanni sakanni commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Draft, and not for merge. This exists to take one measurement in a real run and will be closed once it has.

What is being measured

Whether a change confined to the versioning dataset directory triggers ci-versioning.

ci-versioning passes patterns: '*.cs *.csproj *.sln :(exclude)*AssemblyInfo.cs' to compute-changed-files (ci-versioning/action.yml). No .json token. Measured against a reconstructed fixture built from this repository's real 197-path tree, a dataset-only changeset selects 0 files and the job self-skips to success. That was a simulation. This pull request checks it against the real pipeline.

The change is a single trailing newline on .ci/code/Versioning_Test/Datasets/9.2/Adapters.json. One insertion, no content.

Why it matters

The backfill described in BHoM/internal-tickets#35 edits Objects.json and nothing else. Whether that pull request receives any ci-versioning signal determines what verification it has to carry in its own description, and determines whether a repo-local dataset guard needs to ship before it or after it.

Two outcomes, both useful:

  • ci-versioning self-skips. Confirms the backfill gets no signal from this check, and its verification must be local evidence in the description.
  • ci-versioning runs. Refutes the fixture measurement, and the sequencing built on it needs revisiting.

ci-dataset-compliance is expected to fail here, because the selector :(icase)*datasets*.json matches all 80 files under Versioning_Test/Datasets and DatasetComplianceRunner requires each to deserialise as a BH.oM.Data.Library.Dataset. These are JSON Lines of oM objects and cannot. That is the defect #350 fixes, and its appearance here is a second, incidental confirmation that #350 has to land before the backfill.

Refs BHoM/internal-tickets#35, BHoM/internal-tickets#44.

Whitespace-only trailing newline on a dataset file, to measure in a real run
whether ci-versioning's changed-file patterns select it. Draft, not for merge.

Refs BHoM/internal-tickets#44
@sakanni

sakanni commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Measurement taken, closing as planned.

Result, from the real run (34376932773):

  • ci-versioning: ##[notice]No relevant files changed. Check skipped. Every downstream action ended outcome=skipped, including deps, so resolve-dependencies never ran. Job concluded success. Confirms the fixture measurement: a dataset-only change gets no signal from this check.
  • ci-dataset-compliance: 1 relevant file(s) changed, Coverage: 1 of 1 file(s) examined, then Dataset file did not deserialise into a BH.oM.Data.Library.Dataset object successfully on 9.2/Adapters.json. Failure. Second, incidental confirmation that fix(ci): exclude the versioning test sets and upgrade maps from the dataset compliance pathspec #350 has to land before any pull request touching these files.

Both outcomes were predicted in the description. Branch deleted.

@sakanni sakanni closed this Sep 9, 2026
@sakanni
sakanni deleted the internal-tickets-#44-ProbeDatasetOnlyTrigger branch September 9, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant