Conversation
Whitespace-only trailing newline on a dataset file, to measure in a real run whether ci-versioning's changed-file patterns select it. Draft, not for merge. Refs BHoM/internal-tickets#44
Contributor
Author
|
Measurement taken, closing as planned. Result, from the real run (34376932773):
Both outcomes were predicted in the description. Branch deleted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft, and not for merge. This exists to take one measurement in a real run and will be closed once it has.
What is being measured
Whether a change confined to the versioning dataset directory triggers
ci-versioning.ci-versioningpassespatterns: '*.cs *.csproj *.sln :(exclude)*AssemblyInfo.cs'tocompute-changed-files(ci-versioning/action.yml). No.jsontoken. Measured against a reconstructed fixture built from this repository's real 197-path tree, a dataset-only changeset selects 0 files and the job self-skips to success. That was a simulation. This pull request checks it against the real pipeline.The change is a single trailing newline on
.ci/code/Versioning_Test/Datasets/9.2/Adapters.json. One insertion, no content.Why it matters
The backfill described in
BHoM/internal-tickets#35 editsObjects.jsonand nothing else. Whether that pull request receives anyci-versioningsignal determines what verification it has to carry in its own description, and determines whether a repo-local dataset guard needs to ship before it or after it.Two outcomes, both useful:
ci-versioningself-skips. Confirms the backfill gets no signal from this check, and its verification must be local evidence in the description.ci-versioningruns. Refutes the fixture measurement, and the sequencing built on it needs revisiting.ci-dataset-complianceis expected to fail here, because the selector:(icase)*datasets*.jsonmatches all 80 files underVersioning_Test/DatasetsandDatasetComplianceRunnerrequires each to deserialise as aBH.oM.Data.Library.Dataset. These are JSON Lines of oM objects and cannot. That is the defect #350 fixes, and its appearance here is a second, incidental confirmation that #350 has to land before the backfill.Refs
BHoM/internal-tickets#35,BHoM/internal-tickets#44.