Fix Typology using Name instead of Identifier property - #360
Open
Tom-Kingstone wants to merge 2 commits into
Open
Tom-Kingstone wants to merge 2 commits into
Tom-Kingstone wants to merge 2 commits into
Conversation
Contributor
Author
|
@BHoMBot check required |
|
@Tom-Kingstone to confirm, the following actions are now queued:
There are 13 requests in the queue ahead of you. |
Contributor
Author
|
@Tom-Kingstone to confirm, the following actions are now queued:
There are 4 requests in the queue ahead of you. |
|
@Tom-Kingstone to confirm, the following actions are now queued:
There are 19 requests in the queue ahead of you. |
|
@Tom-Kingstone to confirm, the following actions are now queued:
There are 28 requests in the queue ahead of you. |
jamesramsden-bh
approved these changes
Sep 17, 2026
jamesramsden-bh
left a comment
Contributor
There was a problem hiding this comment.
Tested with beta test script, paying particular attention to tests related to this PR, all passing.
Contributor
Author
|
@BHoMBot check ready-to-merge |
|
@Tom-Kingstone to confirm, the following actions are now queued:
There are 6 requests in the queue ahead of you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
Closes #359
This is fixing a bug found in testing, basically everything but Typology went through alignment with python objects.
Typology needed updating to also upgrade to use Identifier instead of Name.
Test files
The beta test procedure should pass (specifically after utci/walkability heatmap methods the comparison test should return true)
Changelog
Additional comments