Skip to content

Fix Typology using Name instead of Identifier property - #360

Open
Tom-Kingstone wants to merge 2 commits into
developfrom
LadybugTools_Toolkit-#359-FixTypologyIdentifier
Open

Tom-Kingstone wants to merge 2 commits into
developfrom
LadybugTools_Toolkit-#359-FixTypologyIdentifier

Conversation

@Tom-Kingstone

Copy link
Copy Markdown
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #359

This is fixing a bug found in testing, basically everything but Typology went through alignment with python objects.

Typology needed updating to also upgrade to use Identifier instead of Name.

Test files

The beta test procedure should pass (specifically after utci/walkability heatmap methods the comparison test should return true)

Changelog

Additional comments

@Tom-Kingstone Tom-Kingstone self-assigned this Sep 17, 2026
@Tom-Kingstone Tom-Kingstone added the type:bug Error or unexpected behaviour label Sep 17, 2026
@Tom-Kingstone

Tom-Kingstone commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

@BHoMBot check required

@bhombot-ci

bhombot-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 13 requests in the queue ahead of you.

@Tom-Kingstone

Tom-Kingstone commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

@BHoMBot check unit-tests
@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

@bhombot-ci

bhombot-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown

@Tom-Kingstone to confirm, the following actions are now queued:

  • check unit-tests
  • check copyright-compliance
  • check dataset-compliance

There are 4 requests in the queue ahead of you.

@bhombot-ci

bhombot-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 19 requests in the queue ahead of you.

@bhombot-ci

bhombot-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown

@Tom-Kingstone to confirm, the following actions are now queued:

  • check unit-tests
  • check copyright-compliance
  • check dataset-compliance

There are 28 requests in the queue ahead of you.

@jamesramsden-bh jamesramsden-bh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with beta test script, paying particular attention to tests related to this PR, all passing.

@Tom-Kingstone

Copy link
Copy Markdown
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci

bhombot-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown

@Tom-Kingstone to confirm, the following actions are now queued:

  • check ready-to-merge

There are 6 requests in the queue ahead of you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Error or unexpected behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typology class should have Identifier, not Name

2 participants