Removed evaluation column from term management page - #567
Conversation
JohnCox2211
left a comment
JohnCox2211
left a comment
There was a problem hiding this comment.
The column for the midyear and final evaluations is gone, but connected code of the backend is still there. I don't think we use it anywhere else, so it should be removed too it seems in files like termManagement.py, term.py, studentLaborEvaluations.py, studentLaborEvaluations.html.
All of those files have references to variables used by this functionality like isFinalEvaluationOpen or isMidyearEvaluationOpen.
the manageEval Flask route, toggleEval JS function, and isMidyearEvaluationOpen/isFinalEvaluationOpen model fields.
…Team/lsf into 522-remove-evaluation-buttons-from-term-management
…ttps://github.com/BCStudentSoftwareDevTeam/lsf into 522-remove-evaluation-buttons-from-term-management
|
Error upon trying to navigate to the manage terms page. 
There are still references to evaluations like isFinalEvaluationOpen being part of render_template in studentLaborEvaluation.py, and is referenced in studentLaborEvaluation.html. |
…ing midyear/final evaluation support
…ttps://github.com/BCStudentSoftwareDevTeam/lsf into 522-remove-evaluation-buttons-from-term-management
JohnCox2211
left a comment
JohnCox2211
left a comment
There was a problem hiding this comment.
I am still getting the previous peewee error when on the backup database (it is not present when using test)
MImran2002
left a comment
MImran2002
left a comment
There was a problem hiding this comment.
There are multiple .DS_Store being pushed they shouldn't be there along with extensions and fetch head. And this is anothe rtime it happened, it happened with me too I think we should add this in git ignore
…ror/.DS_Store DS_store removed
removed DS_Store
removed file
removed file
|
talked with Brian, we will be keeping the model data to ensure the data is still there, most of the changes are to aim at UI and front-end access and likely backend access too, |
nahom70
added
epic
| sle.delete_instance() | ||
| except DoesNotExist: | ||
| pass | ||
| # Then, save the new record |
There was a problem hiding this comment.
Let's keep the existing comments, unless the code does something else
|
|
||
| </div> | ||
| {% if not existing_final_evaluation and (not existing_midyear_evaluation or isFinalEvaluationOpen) %} | ||
| {% if not existing_evaluation %} |
There was a problem hiding this comment.
- why are we converting existing_final_evaluation to existing evaluation if we are getting rid of evaluations?
- In the issue, are we keeping existing evaluation for any purpose?
6 participants
Fixes #522
Changes:
Removed the Evaluations (Midyear | Final) column from the Term Management table as it is no longer needed. This includes the column header and the corresponding table cell containing the midyear and final evaluation toggle buttons for each term row.
Testing: