Skip to content

Footer - #1813

Merged
RueHaile merged 3 commits into
BCStudentSoftwareDevTeam:developmentfrom
bakobagassas:footer
Sep 18, 2026
Merged

Footer#1813
RueHaile merged 3 commits into
BCStudentSoftwareDevTeam:developmentfrom
bakobagassas:footer

Conversation

@bakobagassas

Copy link
Copy Markdown
Contributor

Issue Description

Fixes issue #1812

On some laptops, the footer of the CELTS app occupies the middle of the screen. This prevents the users from fully seeing their screen as the component covers some of the accordions.

Changes

  • change the max height to min in css and set the floor
  • placed the div in userprofile appropriately and added missing endif statement (whcih I believe was the main reason the bug was not consistent accross profiles.)

Testing

  • checkout footer branch
  • reset database from backup
  • log in as admin
  • go to admin -> setting -> user management
  • add neillz as student staff
  • log in as neillz
  • search for sethu
  • open the participation history accordion
  • The footer should still be fixed at the bottom of the page

@fritzj2
fritzj2 self-requested a review September 18, 2026 15:20

@fritzj2 fritzj2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the code looks good and works as intended. Just make sure that the changes still work when it is updated.

@RueHaile

Copy link
Copy Markdown
Contributor

Good work, looks good to me.

@RueHaile
RueHaile merged commit 86f7f62 into BCStudentSoftwareDevTeam:development Sep 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants