All Celts Training now appears in participation history

[MImran2002]

Issue Description

Fixes issue #1810 #1814

• For All Celts Training (Labor), the student who was manually added after event has finished does not have the event shown up in their participation history. This prevents the student from signing the handbook.
• All CELTS Training (Labor) missing from Participation History. Students who were manually added to an All CELTS Training (Labor) after the event had already ended were correctly shown as having completed the training in roster views, but the event did not appear under their Participation History.
• CELTS labor students were shown the Volunteer Handbook. Students were defaulting to the Volunteer Handbook in their personal information section, including CELTS labor students.
• Inconsistent handbook-signature information when viewing student profiles. CELTS staff viewing a student's profile did not consistently receive the same handbook status information.

Changes

• Removes isCeltsTraining filter from the query in getparticipatedEventsForUser function so that it also includes All CELTS Training (Labor) in the return value.
• Added test case for the All CELTS Training (Labor) being returned from the function.
• Admin and CELTS Labor default will now see Labor Handbook
• The display logic now explicitly distinguishes between:
  • a student viewing their own profile, and
  • an authorized CELTS staff member viewing another student's profile.
• This allows authorized staff to see when a student still needs to sign the handbook or when the student's current handbook signature is valid.
• Change the naming of CELTS Student Handbook to CELTS Labor Handbook to clear confusion.

Jinja Display Logic Refactored

Testing

• Checkout the branch git checkout actPastEventHF
• Pull the latest code git pull
• Reset the test database ./database/reset_database.sh test
• Run the test suite ./tests/run_tests.sh

Participation History

• Create an All CELTS Training (Labor) event and set the event date in the past.
• After the event is created, go to Manage Volunteers and manually add Zach Neill as a volunteer.
• Go to Zach Neill's profile.
• Verify that the All CELTS Training (Labor) event appears under the Participation History accordion.

Handbook Display Logic

Test the handbook section under the following scenarios:

CELTS Labor Student

• Assign Zach Neil as Celts Student Labor by going to Admin> Setting> user management and add him as CELTS student staff
• Open Zach Neill's Profile and click edit Personal Information button
• Verify that the CELTS Labor Handbook is displayed instead of the Volunteer Handbook.
• If no Labor Handbook exists for the current term, verify that the page displays the "No CELTS Labor Handbook available" message.

Volunteer Student

• Open Nyan Lin Zaw's Profile and click edit Personal Information button
• Verify that the CELTS Volunteer Handbook is displayed.
• If no Volunteer Handbook exists for the current term, verify that the page displays the "No Volunteer Handbook available" message.

Handbook Overdue Logic

Test Zach Neil (reset the database) who does not have a handbook signature for the current academic year. Change your view as Zach Neill.

• When Zach Neill have not attended training, verify that his profile displays the message stating that the handbook must be signed at an All Volunteers Training or All CELTS Training (Labor).
• Then create an All CELTS Training (Labor) in the past and have Zach Neill as attended, then go to their profile verify that the Sign the handbook section appears.
• Verify that the signature pad is only displayed when the student is viewing their own profile.
• Verify that the student can save their signature.
• Verify that the confirmation message appears after the signature is successfully saved.

Existing Handbook Signature

• Test a student whose signatureTerm matches the current academic year.
• Verify that the signature pad is not displayed.
• Verify that the profile displays:
  Your handbook signature is good for AY <current academic year>.
• When an authorized CELTS staff member views the same student, verify that the student's handbook signature is shown as valid for the current academic year.

Previous Academic Year Signature

• Test a student whose handbook was signed during a previous academic year.
• Verify that the student is considered handbook overdue.
• Verify that the previous signature does not count as valid for the current academic year.
• Verify that the student is given the appropriate training/signing instructions.

Staff View

• View an overdue student as a CELTS staff/admin user.
• Verify that staff do not receive the student's signature pad.
• If the student has attended the qualifying training but has not signed, verify that staff see the message indicating that the student attended the training but still needs to sign the handbook.
• Verify that CELTS staff with equivalent permissions see the same handbook status for the same student.

[bakobagassas]

let me know when it is ready for another review

[bakobagassas]

I still see the labor handbook link though I have not uploaded any and when I click on the link it shows this

[bakobagassas]

Participation History looks good in the UI side!

[MImran2002]

I still see the labor handbook link though I have not uploaded any and when I click on the link it shows this

Hi I have tested the labor handbook scenario where it has been uploaded, I went to mysql and update the term table to remove the handbook. When the handbook are not available this would be showing

For the links: it was working for me for some reason. Can I see your workflow when you come into work.

[github-actions]

View Code Coverage