Skip to content

solved issue service hours not being displayed in participation history - #1765

Merged
BrianRamsay merged 9 commits into
developmentfrom
display_service_hours
Sep 9, 2026
Merged

solved issue service hours not being displayed in participation history#1765
BrianRamsay merged 9 commits into
developmentfrom
display_service_hours

Conversation

@conwelld

Copy link
Copy Markdown
Contributor

Fixes issue #<1742>

  • there was an issue in celts where service hours were not being displayed in participation history, making it streneous for the user to find their hours and they had to go to the service transcript

Changes

  • added peewee query to find the hours for the specified event, by ascending order
image image

Testing

  • reset the databse and ran it with no issues

@conwelld conwelld self-assigned this Jul 16, 2026
@conwelld
conwelld requested review from BetterRocket and fritzj2 July 16, 2026 19:59
Comment thread app/controllers/main/routes.py Outdated
Comment thread app/controllers/main/routes.py Outdated

@MImran2002 MImran2002 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swap the event dat column with service hours, and n/a would be better than a "-".

MImran2002
MImran2002 previously approved these changes Jul 20, 2026

@MImran2002 MImran2002 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@fritzj2 fritzj2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The number of hours in the service hours column does not match the number of volunteer hours earned on the service transcript for certain students.
Fritzj2 has 73.75 hours tracked on the table, while the service transcript shows he has only 72.
The all-volunteer training should not earn toward service hours and thus shouldn't be included in the table.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

View Code Coverage

@BrianRamsay
BrianRamsay merged commit 8ca38c5 into development Sep 9, 2026
5 checks passed
@BrianRamsay
BrianRamsay deleted the display_service_hours branch September 9, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants