Skip to content

Fix publishprofile workflow - #567

Closed
Akshay Kumar (kumaraksh1) wants to merge 8 commits into
masterfrom
users/kumaraksh/fix-publishprofile-workflow
Closed

Fix publishprofile workflow#567
Akshay Kumar (kumaraksh1) wants to merge 8 commits into
masterfrom
users/kumaraksh/fix-publishprofile-workflow

Conversation

@kumaraksh1

@kumaraksh1 Akshay Kumar (kumaraksh1) commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Separating untrusted PR validation from credentialed deployment to prevent PR-controlled

With the new design, the PR validates that the action builds successfully, but it does not validate an actual Azure deployment before merge.

The validation flow is now:
PR opened
→ npm ci
→ npm run package
→ no credentials and no deployment

PR merged to master/releases/*
→ trusted push workflow runs
→ Azure/ACR authentication
→ builds action from merged commit
→ deploys to the test Web App

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR description that this would mean this workflow cannot be used to test while submitting a PR.

Also, do we have any doc / readme that tells how to test one's PR. If yes, let's update there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants