You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Racer docs now explain what Racer gives you and when it is the right cache to pick. The concept page adds a list of key benefits, a use-case table, a comparison with running separate cache servers, and planning notes. The Gantry, Azure Blob cache, and vLLM guides and the landing page now state the main benefits for each case.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The documentation inaccurately describes node exclusion, recovery from corrupt cached copies, and verification timing during streaming reads, potentially misleading operators and application developers.
Describe corrupt-copy rejection and recovery, not guaranteed read failure
docs/content/concepts/racer.md:56
A corrupt cached copy does not necessarily make the application's read fail. The acquisition path rejects it and can recover from another peer or an authorized origin; cmd/racer-dataplane/src/read/tests/peer_copies.rs:2333-2351 explicitly asserts a successful read in both cases. Please describe rejection and recovery instead of guaranteed failure, so readers do not expect every corruption event to surface as an application error.
Clarify SDK streams bytes before full-range verification completes
docs/content/concepts/racer.md:77
This promises verification of the whole requested range before application consumption, but the SDK streams payload bytes immediately (pkg/racersdk/object.go:232-264) and withholds only the final byte pending completion (pkg/racersdk/object.go:545-582). A later page or completion failure can therefore occur after the application has consumed a prefix. Please describe the successful-completion guarantee instead, so consumers needing all-or-nothing input do not rely on verification before consumption.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Racer docs now explain what Racer gives you and when it is the right cache to pick. The concept page adds a list of key benefits, a use-case table, a comparison with running separate cache servers, and planning notes. The Gantry, Azure Blob cache, and vLLM guides and the landing page now state the main benefits for each case.